-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified scrolling using game.shell.pointerLock #11
base: master
Are you sure you want to change the base?
Conversation
@@ -134,7 +135,7 @@ class InventoryHotbarClient extends InventoryHotbarCommon | |||
ever(document.body).on 'keydown', @keydown | |||
|
|||
super() | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace
I can't get scrolling to work at all with this change (with wheelEnable:true, and the now-default wheelScale:120) testing on latest voxelmetaverse, for unknown reasons. Even when pointer lock is acquired, scrolling the mouse does not change the inventory slots. If I remove the added "if @game.shell.pointerLock" line then scrolling works. |
@deathcap I removed the first whitespace, cant seem to remove the second (im using githubs edit button) as it seems to be added automatically... |
Fixed changes mention in previous PR.