Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add python3 support #15

Closed
wants to merge 1 commit into from
Closed

add python3 support #15

wants to merge 1 commit into from

Conversation

AlJohri
Copy link

@AlJohri AlJohri commented Sep 22, 2016

hi @mikeshultz

  • updated tests to reflect current votesmart data
  • ensure tests pass in both python 2 and python 3
  • code changes were minimal, majority were doctests
    • import urllib2 methods properly for python 2 and 3
    • use .items() instead of .iteritems()

@AlJohri
Copy link
Author

AlJohri commented Jul 4, 2017

bump

@AlJohri AlJohri mentioned this pull request Aug 26, 2017
Open
@AlJohri
Copy link
Author

AlJohri commented Aug 26, 2017

bumping this issue. cc @mikeshultz, @jamesturk. anything I can do to help get this patch accepted? #12 (comment)

@AlJohri
Copy link
Author

AlJohri commented May 29, 2018

bump @mikeshultz, @jamesturk, @travtex

@AlJohri AlJohri closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlJohri