Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix custom plugin doc and build script #4042

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix custom plugin doc and build script #4042

wants to merge 1 commit into from

Conversation

Monokaix
Copy link
Member

What type of PR is this?

/kind bug
/kind cleanup
/kind documentation
/area scheduling
/area deploy

What this PR does / why we need it:

When build custom plugin, we should also re-build base image with CGO enable and musl-gcc.

Which issue(s) this PR fixes:

Fixes #3959

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@volcano-sh-bot volcano-sh-bot added kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 25, 2025
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign monokaix
You can assign the PR to them by writing /assign @monokaix in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added kind/documentation Categorizes issue or PR as related to documentation. area/scheduling area/deploy Issues or PRs related to deploy/helm/build/scripts changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2025
@Monokaix
Copy link
Member Author

cc @hwdef @lowang-bh @archlitchi @JesseStutler

@Monokaix Monokaix force-pushed the custom-plugin branch 4 times, most recently from f8d0b58 to fde82a7 Compare February 25, 2025 11:07
lowang-bh
lowang-bh reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@lowang-bh lowang-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowang-bh lowang-bh lowang-bh left review comments

@jasonliu747 jasonliu747 Awaiting requested review from jasonliu747

@JesseStutler JesseStutler Awaiting requested review from JesseStutler

At least 1 approving review is required to merge this pull request.

Assignees

@lowang-bh lowang-bh

Labels
area/deploy Issues or PRs related to deploy/helm/build/scripts changes area/scheduling kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ascend for Volcano get "Fail to load custom plugins: plugin: not implemented"
3 participants
@Monokaix @volcano-sh-bot @lowang-bh