-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the problem that the pending tasks cannot be scheduled during the backfill action #4029
base: master
Are you sure you want to change the base?
Conversation
…e backfill action Signed-off-by: hansong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Great. But I'm wondering isn't there also a problem in the allocate action? After the break here:
|
It is ok when minMember equals to total replicas.
|
What type of PR is this?
What this PR does / why we need it:
During the backfill action, in the loop of pending tasks, if a previous task fails to match a node or an exception occurs when calling the PrePredicateFn method, all subsequent tasks will stop being scheduled.
Which issue(s) this PR fixes:
Fixes #4028
Special notes for your reviewer:
Does this PR introduce a user-facing change?