Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: fix a bug where the job NodesFitErrors field is not updated when ssn.Allocate failed #4009

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

scheduler: fix a bug where the job NodesFitErrors field is not updated when ssn.Allocate failed #4009

wants to merge 1 commit into from

Conversation

SataQiu
Copy link
Contributor

@SataQiu SataQiu commented Feb 13, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

scheduler: fix a bug where the job NodesFitErrors field is not updated when ssn.Allocate failed

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

scheduler: fix a bug where the job NodesFitErrors field is not updated when ssn.Allocate failed

@volcano-sh-bot volcano-sh-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 13, 2025
@volcano-sh-bot volcano-sh-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 13, 2025
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. area/scheduling area/controllers area/cli area/dependency Issues or PRs related to dependency changes area/webhooks area/deploy Issues or PRs related to deploy/helm/build/scripts changes area/documentation documentation of design or user-guide area/performance Issues or PRs related to performance area/test CI and test related Issues or PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2025
@SataQiu SataQiu mentioned this pull request Feb 13, 2025
Open
@SataQiu SataQiu force-pushed the fix-backfill-20250213 branch from 5cc0922 to f11afe2 Compare February 14, 2025 02:29
@JesseStutler
Copy link
Member

JesseStutler commented Feb 25, 2025 •
edited
Loading

/remove-area cli
/remove-area scheduling
/remove-area controllers
/remove-area dependency
/remove-area webhooks
/remove-area deploy
/remove-area documentation
/remove-area performance
/remove-area test
/remove-kind documentation
/remove-kind feature
/remove-kind failing-test
/remove-kind cleanup
/remove-kind flake

@volcano-sh-bot volcano-sh-bot removed area/cli area/scheduling area/controllers area/dependency Issues or PRs related to dependency changes area/webhooks area/deploy Issues or PRs related to deploy/helm/build/scripts changes area/documentation documentation of design or user-guide labels Feb 25, 2025
@volcano-sh-bot volcano-sh-bot removed area/performance Issues or PRs related to performance kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/flake Categorizes issue or PR as related to a flaky test. labels Feb 25, 2025
@JesseStutler
Copy link
Member

Great, I also met this problem before
/lgtm
/ok-to-test

@volcano-sh-bot volcano-sh-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed area/test CI and test related Issues or PRs labels Feb 25, 2025
@volcano-sh-bot
Copy link
Contributor

@JesseStutler: Those labels are not set on the issue: area/cli, area/scheduling, area/controllers, area/dependency, area/webhooks, area/deploy, area/documentation, area/performance, kind/documentation, kind/feature, kind/failing-test, kind/cleanup, kind/flake

In response to this:

/remove-area cli
/remove-area scheduling
/remove-area controllers
/remove-area dependency
/remove-area webhooks
/remove-area deploy
/remove-area documentation
/remove-area performance
/remove-area test
/remove-kind documentation
/remove-kind feature
/remove-kind failing-test
/remove-kind cleanup
/remove-kind flake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudson741 hudson741 Awaiting requested review from hudson741

@hwdef hwdef Awaiting requested review from hwdef

At least 1 approving review is required to merge this pull request.

Assignees

@JesseStutler JesseStutler

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SataQiu @volcano-sh-bot @JesseStutler