Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] test: add e2e test cases for hypernode #3983

Open
wants to merge 1 commit into
base: network-topology
Choose a base branch
from
Open

[WIP] test: add e2e test cases for hypernode #3983

wants to merge 1 commit into from

Conversation

Xu-Wentao
Copy link

What type of PR is this?

/area test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Support #3928

Special notes for your reviewer:

Use kwok to create multi worker nodes.

Does this PR introduce a user-facing change?

@volcano-sh-bot volcano-sh-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test CI and test related Issues or PRs kind/bug Categorizes issue or PR as related to a bug. labels Jan 23, 2025
@volcano-sh-bot volcano-sh-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 23, 2025
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hwdef
You can assign the PR to them by writing /assign @hwdef in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. area/scheduling area/controllers area/cli area/dependency Issues or PRs related to dependency changes area/webhooks area/deploy Issues or PRs related to deploy/helm/build/scripts changes area/documentation documentation of design or user-guide area/performance Issues or PRs related to performance size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2025
@Xu-Wentao Xu-Wentao force-pushed the dev branch 3 times, most recently from 47667ae to 6ffc27b Compare January 23, 2025 10:51
@Monokaix Monokaix removed kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/scheduling area/controllers area/cli labels Feb 5, 2025
@Monokaix Monokaix removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/dependency Issues or PRs related to dependency changes kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. kind/documentation Categorizes issue or PR as related to documentation. area/webhooks area/deploy Issues or PRs related to deploy/helm/build/scripts changes area/documentation documentation of design or user-guide area/performance Issues or PRs related to performance labels Feb 5, 2025
@Monokaix Monokaix added this to the v1.12 milestone Feb 5, 2025
JesseStutler
JesseStutler reviewed Feb 10, 2025
View reviewed changes
test/e2e/hypernode/kwok.yaml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just write one kwok node yaml and then use a script to create multiple identical kwok nodes. This way of writing is too repetitive.

@JesseStutler
Copy link
Member

You also need to add a workflow action yaml in .github/workflows dir

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 17, 2025
@volcano-sh-bot volcano-sh-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2025
@Xu-Wentao Xu-Wentao force-pushed the dev branch 2 times, most recently from 7e4b44f to 74f4de6 Compare February 17, 2025 13:15
@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseStutler JesseStutler JesseStutler left review comments

@Monokaix Monokaix Awaiting requested review from Monokaix

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

Assignees
No one assigned
Labels
area/test CI and test related Issues or PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
4 participants
@Xu-Wentao @volcano-sh-bot @JesseStutler @Monokaix