Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All k8s dependencies need to be upgraded to v1.32 #3935

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

All k8s dependencies need to be upgraded to v1.32 #3935

wants to merge 2 commits into from
+325 −236

Conversation

danish9039
Copy link

@danish9039
dependency upgrade
a53937b 
Signed-off-by: danish9039 <[email protected]>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 28, 2024
@danish9039
Copy link
Author

/assign

@lowang-bh
Copy link
Member

/ok-to-test

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 29, 2024
@JesseStutler
Copy link
Member

JesseStutler commented Dec 30, 2024 •
edited
Loading

Thanks for your contribution! But we may not merge this PR so quickly. The next version v2.0 will not upgrade the k8s version to v1.32. However, after 2.0 is released, we can consider upgrading the k8s version to v1.32.

@JesseStutler
Copy link
Member

/area dependency

@volcano-sh-bot volcano-sh-bot added the area/dependency Issues or PRs related to dependency changes label Dec 30, 2024
@danish9039
Copy link
Author

Thanks for your contribution! ut we may not merge this PR so quickly. The next version v2.0 will not upgrade the k8s version to v1.32. However, after 2.0 is released, we can consider upgrading the k8s version to v1.32.

thats alright ! looking forward to contribute more in the project

@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2025
@volcano-sh-bot
Copy link
Contributor

@danish9039: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JesseStutler
Copy link
Member

@danish9039 Hi danish, we can go on this PR now

@JesseStutler
Copy link
Member

You can follow this tutorial to upgrade v1.32: https://github.com/volcano-sh/volcano/blob/master/docs/design/adapt-k8s-todo.md, could you finish this before Feb 21? The upgrade time will be tight

@Monokaix Monokaix added this to the v1.12 milestone Feb 5, 2025
@danish9039
Copy link
Author

danish9039 commented Feb 7, 2025 •
edited
Loading

You can follow this tutorial to upgrade v1.32: https://github.com/volcano-sh/volcano/blob/master/docs/design/adapt-k8s-todo.md, could you finish this before Feb 21? The upgrade time will be tight

yeah sure ! , i'll address this soon

@JesseStutler
Copy link
Member

JesseStutler commented Feb 17, 2025 •
edited
Loading

@danish9039 Hi danish, how is the current progress? We need your feedback before Wednesday. It's getting close to February 21st, and we need to complete this PR as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcorj-mizar alcorj-mizar Awaiting requested review from alcorj-mizar

@k82cn k82cn Awaiting requested review from k82cn

@Monokaix Monokaix Awaiting requested review from Monokaix

At least 1 approving review is required to merge this pull request.

Assignees

@danish9039 danish9039

Labels
area/dependency Issues or PRs related to dependency changes needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
5 participants
@danish9039 @volcano-sh-bot @lowang-bh @JesseStutler @Monokaix