Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(language-service): stricter context isolation for Service interface #100

Merged
merged 2 commits into from
Dec 4, 2023
Merged

refactor(language-service): stricter context isolation for Service interface #100

merged 2 commits into from
Dec 4, 2023

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Dec 4, 2023 •
edited
Loading

Changes

  • Service interface has been renamed to ServicePlugin
  • Trigger characters are no longer exposed when creating a service plugin instance, but are exposed in advance as properties of ServicePluginFactory. Therefore the language server no longer needs to create fake service plugin instances in order to collect trigger characters.
  • Services are no longer coupled with SharedModules, and the modules that the service depends on should be exposed through the parameters of the create function

@johnsoncodehk johnsoncodehk merged commit 06c778d into master Dec 4, 2023
6 checks passed
@johnsoncodehk johnsoncodehk deleted the service-plugin-context branch December 4, 2023 08:38
@johnsoncodehk johnsoncodehk mentioned this pull request Dec 4, 2023
Open
42 tasks
johnsoncodehk added a commit to volarjs/services that referenced this pull request Dec 4, 2023
@johnsoncodehk
refactor for volarjs/volar.js#100
7b9e601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnsoncodehk