Skip to content

feat(gui): enable DPI awareness to avoid bad resolution - #1125

Open
ACGNnsj wants to merge 3 commits into
voicepaw:mainfrom
ACGNnsj:main
Open

feat(gui): enable DPI awareness to avoid bad resolution#1125
ACGNnsj wants to merge 3 commits into
voicepaw:mainfrom
ACGNnsj:main

Conversation

@ACGNnsj

@ACGNnsj ACGNnsj commented Mar 13, 2024

Copy link
Copy Markdown

Description of change

copilot:all

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • This pull request follows Contributing.md
  • This pull request links relevant issues as Fixes #0000
  • pre-commit run -a passes with this change or ci passes
  • poetry run pytest passes with this change or ci passes
  • (There are new or updated unit tests validating the change)
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

@codecov

codecov Bot commented Mar 13, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.22%. Comparing base (3f537b0) to head (9abacba).
⚠️ Report is 367 commits behind head on main.

Files with missing lines Patch % Lines
src/so_vits_svc_fork/gui.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
- Coverage   19.25%   19.22%   -0.03%     
==========================================
  Files          39       39              
  Lines        3496     3500       +4     
  Branches      497      498       +1     
==========================================
  Hits          673      673              
- Misses       2804     2808       +4     
  Partials       19       19              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@34j 34j changed the title Enable DPI awareness to avoid bad resolution feat(gui): enable DPI awareness to avoid bad resolution Mar 30, 2024
@34j

34j commented Apr 6, 2024

Copy link
Copy Markdown
Collaborator

This change makes the window to be too small, so the window scale needs to be changed accordingly, but it's a pain to do this
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants