Fix Volume inspect always yields null Options #8253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjun
reviewed
Sep 4, 2018
|
Concur with @wjun for the Group1 volume inspect test. |
when doing docker volume inspect, the Options filed of the result is always null. The VolumeInspect() function fetches volume info. But when constructing the Volume using for docker, it doesn't assign correponding values into the Options fields. Now the fix fills this field by changing the NewVolumeModel fuction. The VolumeCreate() function also returns a Volume struct which unfills Options field. But I find no usage of its detail info. Thus, the fix make no changes to this function.
YanzhaoLi
force-pushed
the
topic/fix-volumeinspect-yields-null-options
branch
from
4133bc2 to
45e0e3e
Compare
wjun
approved these changes
Nov 23, 2018
YanzhaoLi
requested review from
alanrenouf and
renmaosheng
and removed request for
alanrenouf
renmaosheng
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing
docker volume inspect, theOptionsfield of the result isalways null.
The
VolumeInspect()function fetches volume info and constructsthe
Volumestruct. But when constructing the struct, it doesn't assigncorresponding values into the
Optionsfields ofVolumestruct.The fix fills this field by modifying the
NewVolumeModel()function.The
VolumeCreate()function also returns aVolumestruct whichleaves
Optionsfield empty. But I find no usage of its detail info. Thus,the fix makes no changes to this function.
Fix #7325
[specific ci=1-20-Docker-Volume-Inspect]