🐛 (x-port vc-9.0.0) Do not patch a zone with finalizer if it is being deleted #917
+217
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deleted (vmware-tanzu#913) API server rejects Patch requests when the zone controller is attempting to add a finalizer to the zone, causing the watcher to never start. And since the watcher is the entity removing the finalizer, the zone stays stuck in deletion forever. This change skips a zone from being patched if the zone is being deleted. Additionally, do not watch folders backing a zone if the zone is marked for deletion and the zone does not contain the finalizer. This can happen in situations where the zone controller has already removed the finalizer after stopping the watcher, but the zone is somehow not removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
API server rejects Patch requests when the zone controller is attempting to add a finalizer to the zone, causing the watcher to never start. And since the watcher is the entity removing the finalizer, the zone stays stuck in deletion forever. This change skips a zone from being patched if the zone is being deleted.
Additionally, do not watch folders backing a zone if the zone is marked for deletion and the zone does not contain the finalizer. This can happen in situations where the zone controller has already removed the finalizer after stopping the watcher, but the zone is somehow not removed.
Are there any special notes for your reviewer:
This is a crossport of: #913
Please add a release note if necessary: