Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce rfc-0003-intermediate-value-crds #70

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

waciumawanjohi
Copy link
Contributor

No description provided.

@waciumawanjohi waciumawanjohi added this to the 1.0+ milestone Sep 7, 2021
@waciumawanjohi waciumawanjohi added the rfc Requests For Comment label Sep 7, 2021
Copy link
Contributor

@sclevine sclevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely think we should make it easy to see inputs/outputs, but I like the Workload status alternative more than creating additional resources.

- Create an IntermediateSourceValue, IntermediateImageValue, IntermediateConfigValue. This is
a small interation on IntermediateValue CRD.
- Store the information on the workload status. This would mean creating fewer objects in etcd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll end up wanting to store this information in Workload status regardless, so that we can provide traceability for active (and maybe even recent) artifacts. Attempting to trace artifacts by following the created resources would be significantly slower.

strange way (probably kpack will complain that it is misconfigured). If the operator examines
the GitResource, they will see that it is behaving as expected. By creating an intermediate
value CRD, the operator would be able to examine the field and directly observe the mistake.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operator can check the value interpolated into the kpack Image, where the error is reported.

@waciumawanjohi
Copy link
Contributor Author

Closing RFC 3 in favor of RFC 14.

@waciumawanjohi waciumawanjohi force-pushed the rfc-0003-intermediate-value-crds branch from 6935347 to bf5b310 Compare November 11, 2021 21:43
@netlify
Copy link

netlify bot commented Nov 11, 2021

✔️ Deploy Preview for elated-stonebraker-105904 canceled.

🔨 Explore the source changes: 452856f

🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/61a530c0fe063e000785acd5

## Status: Withdrawn
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotating the status as Withdrawn

@waciumawanjohi waciumawanjohi force-pushed the rfc-0003-intermediate-value-crds branch from bf5b310 to 0e2193d Compare November 29, 2021 19:55
@waciumawanjohi waciumawanjohi marked this pull request as ready for review November 29, 2021 19:55
Withdrawing in favor of RFC 0014
@waciumawanjohi waciumawanjohi force-pushed the rfc-0003-intermediate-value-crds branch from 0e2193d to 452856f Compare November 29, 2021 19:57
@jwntrs jwntrs removed this from the 0.2.0+ milestone Jan 23, 2022
@squeedee squeedee marked this pull request as draft February 22, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc Requests For Comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants