-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce rfc-0003-intermediate-value-crds #70
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely think we should make it easy to see inputs/outputs, but I like the Workload status alternative more than creating additional resources.
- Create an IntermediateSourceValue, IntermediateImageValue, IntermediateConfigValue. This is | ||
a small interation on IntermediateValue CRD. | ||
- Store the information on the workload status. This would mean creating fewer objects in etcd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll end up wanting to store this information in Workload status regardless, so that we can provide traceability for active (and maybe even recent) artifacts. Attempting to trace artifacts by following the created resources would be significantly slower.
strange way (probably kpack will complain that it is misconfigured). If the operator examines | ||
the GitResource, they will see that it is behaving as expected. By creating an intermediate | ||
value CRD, the operator would be able to examine the field and directly observe the mistake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The operator can check the value interpolated into the kpack Image, where the error is reported.
Closing RFC 3 in favor of RFC 14. |
6935347
to
bf5b310
Compare
✔️ Deploy Preview for elated-stonebraker-105904 canceled. 🔨 Explore the source changes: 452856f 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/61a530c0fe063e000785acd5 |
## Status: Withdrawn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annotating the status as Withdrawn
bf5b310
to
0e2193d
Compare
Withdrawing in favor of RFC 0014
0e2193d
to
452856f
Compare
No description provided.