RFC: Add matchFields and matchLabels to top level of blueprints #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for elated-stonebraker-105904 canceled. 🔨 Explore the source changes: 32895a1 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/6220f52f1233b20008c9b14b |
|
Hello @jwntrs!, thanks for opening your first Pull Request. Someone will review it soon. Thank you for committing to make Cartographer better |
|
One of the asks from the OSS slack channel was for clarity in naming. I think the name or at least title for this PR and for the RFC might be better as |
jwntrs
changed the title
scothis
reviewed
Feb 11, 2022
squeedee
approved these changes
Feb 16, 2022
scothis
reviewed
Feb 16, 2022
jwntrs
changed the title
martyspiewak
approved these changes
Feb 17, 2022
squeedee
approved these changes
Feb 22, 2022
sclevine
approved these changes
Feb 23, 2022
waciumawanjohi
approved these changes
Feb 24, 2022
cirocosta
reviewed
Feb 25, 2022
Co-authored-by: Ciro S. Costa <[email protected]>
sclevine
suggested changes
Feb 28, 2022
sclevine
approved these changes
Feb 28, 2022
3 tasks
cirocosta
reviewed
Mar 3, 2022
Co-authored-by: Ciro S. Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add matchFields and matchLabels to top level of blueprints
Readable