Draft: Introduce rfc-0012-discoverable-input-fields #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for elated-stonebraker-105904 canceled. 🔨 Explore the source changes: c1fd0ff 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/61b79911b62a2200074cb009 |
waciumawanjohi
force-pushed
the
rfc-0012-discoverable-input-fields
branch
from
3d75c72 to
c1fd0ff
Compare
scothis
reviewed
Dec 14, 2021
| 1. All of the named params used in the template. | ||
| 2. All of the workload fields used in the template. | ||
|
|
||
| When a supply chain is submitted to the cluster, the supply chain controller updates its status |
There was a problem hiding this comment.
Type checking is typically either static at compile time, or dynamic at runtime. This feels like it's trying to do static analysis at runtime.
Comment on lines
+19
to
+20
| 1. All of the named params used in the template. | ||
| 2. All of the workload fields used in the template. |
There was a problem hiding this comment.
How do you expect this information to be maintained as the template language evolves? I worry without careful planning, this contract could end up limiting the expressiveness of the templates. For example, how do you see ytt based templates working in this model?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.