Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated build.sh to use a json for files #910

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Apr 30, 2024

Summary of Pull Request

Updated build.sh to allow for it to have the same look as download.sh for menu, also moved all build files into project.json.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #915

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@burnsjared0415 burnsjared0415 requested a review from a team as a code owner April 30, 2024 22:06
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Apr 30, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat-/update-build.sh-and-project.json branch from 137c22d to 3e394b5 Compare April 30, 2024 22:07
@tenthirtyam tenthirtyam requested review from tenthirtyam and removed request for vmwghbot April 30, 2024 23:00
@tenthirtyam tenthirtyam added this to the v0.20.0 milestone Apr 30, 2024
@tenthirtyam tenthirtyam added the type/enhancement Enhancement label Apr 30, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat-/update-build.sh-and-project.json branch 2 times, most recently from 08baedd to 08b3f31 Compare May 1, 2024 00:57
@tenthirtyam tenthirtyam force-pushed the feat-/update-build.sh-and-project.json branch from 08b3f31 to cff3a3c Compare May 6, 2024 02:45
@burnsjared0415 burnsjared0415 force-pushed the feat-/update-build.sh-and-project.json branch from cff3a3c to ea59fba Compare May 13, 2024 17:08
@tenthirtyam tenthirtyam force-pushed the feat-/update-build.sh-and-project.json branch 3 times, most recently from 41a5cc8 to 30f87b1 Compare May 14, 2024 04:01
@burnsjared0415 burnsjared0415 force-pushed the feat-/update-build.sh-and-project.json branch 2 times, most recently from 2fe7cee to 30e30d8 Compare May 14, 2024 14:54
@tenthirtyam tenthirtyam force-pushed the feat-/update-build.sh-and-project.json branch 2 times, most recently from d8720e4 to ff58a4e Compare May 15, 2024 15:14
Updated build.sh to allow for it to have the same look as download.sh for menu, also moved all build files into project.json.

Signed-off-by: Jared Burns <[email protected]>
Co-Authored-By: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the feat-/update-build.sh-and-project.json branch from ff58a4e to 03b944d Compare May 15, 2024 15:25
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam merged commit 9bead62 into vmware-samples:develop May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required Contributor License Agreement Not Required type/enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add variable validation for build user case and length
3 participants