Skip to content

[Model] use AutoWeightsLoader for bart #18299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Model] use AutoWeightsLoader for bart #18299

wants to merge 1 commit into from
+72 −70

Conversation

calvin0327
Copy link
Contributor

@calvin0327 calvin0327 commented May 17, 2025 •
edited by github-actions bot
Loading

FIX (partial) #15697

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@calvin0327
Copy link
Contributor Author

@lengrongfu PTAL

@calvin0327 calvin0327 force-pushed the autoweights-for-bart branch from e647f4b to af0f5d3 Compare May 17, 2025 08:24
@lengrongfu
Copy link
Contributor

Thanks for working on this, there are some comments.

@calvin0327 calvin0327 force-pushed the autoweights-for-bart branch from af0f5d3 to 5243921 Compare May 17, 2025 09:53
@calvin0327 calvin0327 force-pushed the autoweights-for-bart branch from 5243921 to 1a1b005 Compare May 18, 2025 03:24
@calvin0327 calvin0327 force-pushed the autoweights-for-bart branch from 1a1b005 to d2a3759 Compare May 18, 2025 04:02
DarkLight1337
DarkLight1337 reviewed May 18, 2025
View reviewed changes
vllm/model_executor/models/bart.py
Comment on lines +854 to 856
lm_head_in_param = model_params_dict['lm_head.weight']
lm_head_in_weight_loader = getattr(lm_head_in_param, "weight_loader",
default_weight_loader)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part should be in the outer model because it's where lm_head is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the method for loading model weights in this model is different from other models. Do you have any suggestions on how to modify this part?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengrongfu lengrongfu lengrongfu left review comments

@DarkLight1337 DarkLight1337 DarkLight1337 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calvin0327 @lengrongfu @DarkLight1337