Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copyright year to auto get current year #13561

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

wilsonwu
Copy link
Contributor

@wilsonwu wilsonwu commented Feb 19, 2025

The copyright year is still 2024:
image

after fix like below:
image

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 19, 2025
@wilsonwu wilsonwu changed the title docs: fix copyright year to auto get current year Fix copyright year to auto get current year Feb 19, 2025
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 19, 2025
@comaniac comaniac enabled auto-merge (squash) February 19, 2025 16:14
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ... one super trivial suggestion, which is to specify UTC as the time zone, instead of using the timezone of whatever system is building the docs (which may be UTC already).

I realize this only has an impact a few hours of the year, so it really doesn't matter!

@@ -27,7 +28,7 @@
# -- Project information -----------------------------------------------------

project = 'vLLM'
copyright = '2024, vLLM Team'
copyright = f'{datetime.datetime.now().year}, vLLM Team'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
copyright = f'{datetime.datetime.now().year}, vLLM Team'
copyright = f'{datetime.datetime.now(datetime.timezone.utc).year}, vLLM Team'

@comaniac comaniac merged commit 01c184b into vllm-project:main Feb 19, 2025
31 of 40 checks passed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants