-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copyright year to auto get current year #13561
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Wilson Wu <[email protected]>
Signed-off-by: Wilson Wu <[email protected]>
cb81586
to
a764324
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ... one super trivial suggestion, which is to specify UTC as the time zone, instead of using the timezone of whatever system is building the docs (which may be UTC already).
I realize this only has an impact a few hours of the year, so it really doesn't matter!
@@ -27,7 +28,7 @@ | |||
# -- Project information ----------------------------------------------------- | |||
|
|||
project = 'vLLM' | |||
copyright = '2024, vLLM Team' | |||
copyright = f'{datetime.datetime.now().year}, vLLM Team' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copyright = f'{datetime.datetime.now().year}, vLLM Team' | |
copyright = f'{datetime.datetime.now(datetime.timezone.utc).year}, vLLM Team' |
The copyright year is still 2024:

after fix like below:
