Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Make log statistics interval configurable #13356

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sakalya
Copy link

@Sakalya Sakalya commented Feb 16, 2025

This PR aims to make "interval" for logging stats configurable.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 16, 2025
@Sakalya Sakalya force-pushed the add_log_stats_interval branch 7 times, most recently from 87df0fa to 04346f6 Compare February 16, 2025 12:33
@Sakalya
Copy link
Author

Sakalya commented Feb 16, 2025

@markmc Can you help to review this please ?

@Sakalya Sakalya force-pushed the add_log_stats_interval branch 3 times, most recently from c3f0dac to c0af787 Compare February 19, 2025 03:21
@NickLucche
Copy link
Contributor

Thanks for your PR!
I don't think you need to ping the whole squad of maintainers to review this though 🤔

PR probably belongs to the [Misc] category. Also, try to address the DCO check to make it ready for merging first.

Signed-off-by: Sakalya Deshpande <[email protected]>

Signed-off-by: Sakalya Deshpande <[email protected]>
Signed-off-by: Sakalya Deshpande <[email protected]>
@Sakalya Sakalya force-pushed the add_log_stats_interval branch from c0af787 to 08cb979 Compare February 19, 2025 13:19
@Sakalya
Copy link
Author

Sakalya commented Feb 19, 2025

Thanks @NickLucche. I have addressed DCO failures. Could you please help to review the PR ?

@Sakalya Sakalya changed the title Make log statistics interval configurable [Misc] Make log statistics interval configurable Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants