-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Avoid calling unnecessary hf_list_repo_files
for local model path
#13348
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxdebayser actually had the same PR #13292 but I feel like this PR is a bit cleaner?
Oh, didn't notice that there has been a same PR, my bad! 😅 |
@Isotr0py , no problem, thanks for also proposing a fix for this problem! @ywang96 , I agree that this PR also fixes the issue. I think it comes down to personal style preferences, so either way is fine by me. My personal view here is that the code in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hf_list_repo_files
calling when model repo is local:hf_list_repo_files
calling if the model repo is local so that we can prevent misleading error logs.