Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 88 as the line length to be compatible with Black #13347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

houseroad
Copy link
Contributor

@houseroad houseroad commented Feb 16, 2025

Black by default uses 88 characters as line length, and reasoning is here: https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length

To be compatible with Black, using 88 seems a wise choice.

@houseroad houseroad marked this pull request as ready for review February 16, 2025 05:44
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py
Copy link
Collaborator

But PEP-8 recommends maximum line length with 79 characters: https://peps.python.org/pep-0008/#maximum-line-length. We should use PEP-8 standard instead of black's default value here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants