Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix 2 Node and Spec Decode tests #13341

Merged
merged 6 commits into from
Feb 16, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Feb 16, 2025

Fix 2-Node test OOM failure in distributed/test_pipeline_parallel.py::test_tp_language_generation[microsoft/Phi-3.5-MoE-instruct-parallel_setup18-ray-0-auto-test_option

Fix Spec Decode failure in spec_decode/e2e/test_ngram_correctness.py::test_ngram_e2e_greedy_correctness[1--1-1-256-test_llm_kwargs0-baseline_llm_kwargs0-per_test_common_llm_kwargs0-common_llm_kwargs0]

Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 16, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 changed the title [Bugfix] Fix 2 Node tests [Bugfix] Fix 2 Node and Spec Decode tests Feb 16, 2025
@youkaichao
Copy link
Member

how is it related with

[2025-02-13T14:15:29Z] NotImplementedError: Prefix caching is not supported with sliding window. Run with --disable-sliding-window to use prefix caching.

?

@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Feb 16, 2025

how is it related with

[2025-02-13T14:15:29Z] NotImplementedError: Prefix caching is not supported with sliding window. Run with --disable-sliding-window to use prefix caching.

?

It seems that sliding window is somehow enabled when testing Phi3.5-MoE in PP (2 node) test

@youkaichao
Copy link
Member

how is it related with

[2025-02-13T14:15:29Z] NotImplementedError: Prefix caching is not supported with sliding window. Run with --disable-sliding-window to use prefix caching.

?

It seems that sliding window is somehow enabled when testing Phi3.5-MoE in PP (2 node) test

And how is this PR fixing that?

@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Feb 16, 2025

I'm still trying to fix it... 😓 the test passes when I run it locally (single node) so it's difficult to debug.

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Copy link
Member Author

The tests should pass now

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@youkaichao youkaichao merged commit 5d2965b into vllm-project:main Feb 16, 2025
44 of 47 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-2node branch February 16, 2025 14:27
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants