Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LMM] Implement merged multimodal processor for whisper #13278

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Feb 14, 2025

TODO

  • Fix profiling issue
  • Add processor test

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
@Isotr0py Isotr0py marked this pull request as ready for review February 18, 2025 10:42
prompt: Union[str, list[int]],
mm_data: MultiModalDataDict,
) -> Union[str, list[int]]:
return [0]
Copy link
Member

@DarkLight1337 DarkLight1337 Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ywang96 is it safe to change the encoder prompt given the change in vllm/multimodal/profiling.py?

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need @ywang96 to comment on the profiling changes.

@DarkLight1337
Copy link
Member

After this PR, can you update the model development docs with some info on how to implement merged multi-modal processor for encoder-decoder models?

@Isotr0py
Copy link
Collaborator Author

Isotr0py commented Feb 19, 2025

can you update the model development docs with some info on how to implement merged multi-modal processor for encoder-decoder models?

Yes, I will add a doc using whisper and florence-2 as e2e example respectively after this PR and #13320 merged, because there is also a minor change on EncDecMultimodalProcessor to fit text-only x-attn VLM in that PR. (That PR should be ready before the end of this weekend)

Signed-off-by: Isotr0py <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants