-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GPUModelRunnerBase load_model method to include device param #13037
Refactor GPUModelRunnerBase load_model method to include device param #13037
Conversation
…eter in DeviceMemoryProfiler
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
@ywang96 Could review this PR pls? thank u |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,I think this is reasonable, @ywang96
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too - I think we should also include this change in V1? I'm also curious how no other users reported this before since this code is pretty old...
this matters if users have multiple vllm instances in the same process, which is indeed a rare case. usually, we set the current device in pytorch, and then most of the code do not need to be aware of it. |
FIX #13036