Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GPUModelRunnerBase load_model method to include device param #13037

Merged

Conversation

Zzhiter
Copy link
Contributor

@Zzhiter Zzhiter commented Feb 10, 2025

FIX #13036

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Zzhiter
Copy link
Contributor Author

Zzhiter commented Feb 19, 2025

@ywang96 Could review this PR pls? thank u

Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,I think this is reasonable, @ywang96

@jeejeelee jeejeelee requested a review from ywang96 February 19, 2025 06:26
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too - I think we should also include this change in V1? I'm also curious how no other users reported this before since this code is pretty old...

cc @WoosukKwon @youkaichao

@youkaichao youkaichao merged commit fdc5df6 into vllm-project:main Feb 19, 2025
18 of 21 checks passed
@youkaichao
Copy link
Member

LGTM too - I think we should also include this change in V1? I'm also curious how no other users reported this before since this code is pretty old...

cc @WoosukKwon @youkaichao

this matters if users have multiple vllm instances in the same process, which is indeed a rare case.

usually, we set the current device in pytorch, and then most of the code do not need to be aware of it.

xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect Device Handling in DeviceMemoryProfiler Causes Zero Memory Usage Log
4 participants