-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge similar examples in offline_inference
into single basic
example
#12737
Conversation
…mple Signed-off-by: Harry Mellor <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
…li.py` Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks for the cleanup
Here's a link to the multi-file example that was created for posterity https://vllm--12737.org.readthedocs.build/en/12737/getting_started/examples/basic.html |
Signed-off-by: Harry Mellor <[email protected]>
Head branch was pushed to by a user without write access
Signed-off-by: Harry Mellor <[email protected]>
Motivation:
Changes:
basic.py
,chat.py
,classify.py
,embed.py
,generate.py
,score.py
toexamples/offline_inference/basic
because they were almost identical:examples/offline_inference/basic
walking through all the contained scriptsArgumentParser
for allEngineArgs
to each of these scripts (exceptbasic.py
)ArgumentParser
for someSamplingParams
forchat.py
andgenerate.py
examples/offline_inference/cli.py
as it's no longer relevantexamples/offline_inference/aqlm_example.py
examples/offline_inference/arctic.py
examples/offline_inference/basic_with_model_default_sampling.py
examples/offline_inference/cpu_offload.py
examples/offline_inference/gguf_inference.py