Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Separate hf dataset sampling function from benchmark_serving.py #12447

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Jan 26, 2025

  • To support different VLM datasets, the sampling function is growing large and complex in benchmark_serving.py
  • This PR aims to separate and decouple dataset sampling function from benchmark_serving.py to keep benchmark script clean

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py requested a review from ywang96 January 26, 2025 16:05
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this PR.

Overall I think if we're going to create a separate datatset_sample_func.py file, then we should consolidate all dataset sampling functions in there (ShareGPT, Sonnet, Random, etc).

Absolutely no rush if you have other priorities to focus on.

@Isotr0py Isotr0py marked this pull request as draft February 18, 2025 13:42
@Isotr0py Isotr0py marked this pull request as ready for review February 19, 2025 16:27
@Isotr0py
Copy link
Collaborator Author

@ywang96 I have migrated all datasets from benchmark_serving.py to datatset_sample_func.py, PTAL!

@ywang96
Copy link
Member

ywang96 commented Feb 20, 2025

:O Sorry I missed this PR!

@Shaoting-Feng Since you're also interested in working on this, maybe you can take a first pass (and try to see how to integrate this with benchmark_throughput.py)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants