os: don't resolve symlinks in find_abs_path_of_executable()

[davidebeatrici]

This fixes aliases and wrappers being ignored.

Resolving the symlinks can cause breakage, an example is coreutils: commands such as echo are just a symlink to a single binary. The name of the symlink tells the program which tool is requested.

Or even worse, in the case of security helpers such as firejail: a symlink is created in one of the top priority folders in PATH, so that firejail steps in and knows what to run.
Resolving the symlink would make the program run outside a jail!

---

Fixes #24759.

[huly-for-github]

Connected to Huly®: V_0.6-23178

[davidebeatrici]

I will replace the uppercase letter in the commit (for consistency) when this is approved.

[spytheman]

I will replace the uppercase letter in the commit (for consistency) when this is approved.

do not bother with editing it, the title of the commit in master does not depend on it (it is the title of the PR by default, but can be edited, when the PR is squash merged into master).

i.e. you can just push new commits to the same branch, no need to change the old for cosmetic stuff like typos/capitalization

[davidebeatrici]

Alright, thank you.

[spytheman]

You are welcome, I am happy to help.

[spytheman]

Looks good so far, only a test for the issue, remains to be added.

[davidebeatrici]

I believe the "Ensure code is well formatted" should be in a separate, dedicated workflow. That way it's clear right away what the problem is and only one test fails.

[davidebeatrici]

On macOS:

 FAIL  [39/49] C:   329.7 ms, R:     9.791 ms vlib/os/find_abs_path_of_executable_test.v
testsuite_begin, tfolder = /tmp/v_501/tsession_1eee5cf80_01JYDG3BK5XX0VAQN6ABY567GG/filepath_tests
[/Users/runner/work/v/v/你好 my $path, @с интервали/vlib/os/find_abs_path_of_executable_test.v:34] os.abs_path(myclang_file): /tmp/v_501/tsession_1eee5cf80_01JYDG3BK5XX0VAQN6ABY567GG/filepath_tests/exe/myclang
[/Users/runner/work/v/v/你好 my $path, @с интервали/vlib/os/find_abs_path_of_executable_test.v:35] os.real_path(myclang_file): /private/tmp/v_501/tsession_1eee5cf80_01JYDG3BK5XX0VAQN6ABY567GG/filepath_tests/exe/myclang
[/Users/runner/work/v/v/你好 my $path, @с интервали/vlib/os/find_abs_path_of_executable_test.v:36] os.is_executable(myclang_file): true
[/Users/runner/work/v/v/你好 my $path, @с интервали/vlib/os/find_abs_path_of_executable_test.v:45] os.abs_path(mylink_file): /tmp/v_501/tsession_1eee5cf80_01JYDG3BK5XX0VAQN6ABY567GG/filepath_tests/mylink
[/Users/runner/work/v/v/你好 my $path, @с интервали/vlib/os/find_abs_path_of_executable_test.v:46] os.real_path(mylink_file): /private/tmp/v_501/tsession_1eee5cf80_01JYDG3BK5XX0VAQN6ABY567GG/filepath_tests/exe/myclang
[/Users/runner/work/v/v/你好 my $path, @с интервали/vlib/os/find_abs_path_of_executable_test.v:47] os.is_executable(mylink_file): true
[/Users/runner/work/v/v/你好 my $path, @с интервали/vlib/os/find_abs_path_of_executable_test.v:70] fpath: /tmp/v_501/tsession_1eee5cf80_01JYDG3BK5XX0VAQN6ABY567GG/filepath_tests/exe/myclang
[/Users/runner/work/v/v/你好 my $path, @с интервали/vlib/os/find_abs_path_of_executable_test.v:70] fpath: /private/tmp/v_501/tsession_1eee5cf80_01JYDG3BK5XX0VAQN6ABY567GG/filepath_tests/mylink
/Users/runner/work/v/v/你好 my $path, @с интервали/vlib/os/find_abs_path_of_executable_test.v:53: fn test_find_abs_path_of_executable
  > assert find_and_check('mylink') == mylink_file
    Left value (len: 86):
      `/private/tmp/v_501/tsession_1eee5cf80_01JYDG3BK5XX0VAQN6ABY567GG/filepath_tests/mylink`
    Right value (len: 78):
      `/tmp/v_501/tsession_1eee5cf80_01JYDG3BK5XX0VAQN6ABY567GG/filepath_tests/mylink`

Definitely unexpected...

[spytheman]

I believe the "Ensure code is well formatted" should be in a separate, dedicated workflow. That way it's clear right away what the problem is and only one test fails.

It is deliberately put at the start of all time consuming jobs, to save CI time, for code that is not even formatted. Many people are sloppy, and having the CI run sanitized jobs that each take 2-3 hours, results in a very long CI queue, given that often there are 3-4 active PRs with new commits in them...

[spytheman]

Use cp cmd/tools/git_pre_commit_hook.vsh .git/hooks/pre-commit run on top of your V repo, to make sure, that all changed code is formatted.

[spytheman]

On macos:

0[10:32:58]@m1: (master) /opt/v $ ls -la /tmp
lrwxr-xr-x@ 1 root  wheel  11  4 Май 08:39 /tmp -> private/tmp

Imho use const tfolder = os.join_path(os.real_path(os.vtmp_dir()), 'filepath_tests') .

[davidebeatrici]

I'm going to wait for the checks to finish before finalizing the PR.

It is deliberately put at the start of all time consuming jobs, to save CI time, for code that is not even formatted. Many people are sloppy, and having the CI run sanitized jobs that each take 2-3 hours, results in a very long CI queue, given that often there are 3-4 active PRs with new commits in them...

Makes sense, I didn't know the heavy jobs took so long.

Use cp cmd/tools/git_pre_commit_hook.vsh .git/hooks/pre-commit run on top of your V repo, to make sure, that all changed code is formatted.

Oh, cool!

@Krzmbrzl @Hartmnt We could implement something similar in our project(s).

[spytheman]

Excellent work.

[davidebeatrici]

Thank you for your review!