Check the timer isn't expired (ringing) before resetting the mask #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timer app issues a short buzz once and then disappears. There is no trace left that the timer finished or how long ago. This change makes the motor start ringing and presents a timer counter. The timer stops buzzing after 10 seconds, and finally resets after 1 minute.
This prevents the motorController from buzzing infinitely while the watch is sleeping.
|
Seeing as you have experience reviewing pull requests, should I have just commented with the suggested code change in the original PR , or is opening a PR on the user's fork like this better? I'm new to reviewing/collaborating on PRs like this :). |
vkareh
force-pushed
the
timer-ringing
branch
from
44389c6 to
684acc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you could set the "reset" text for the expired timer to start by holding down and releasing:
This fixes that by checking the expired timer isn't ringing before allowing the mask to be reset:
