Customizable 404 page #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The text in the different languages (pageNotFound.n3) should be decided in English first, then translations can be done or aligned with it. |
…tandard 404 error page
|
@chenejac I removed not used error templates and not used translations. |
chenejac
previously approved these changes
Mar 8, 2025
chenejac
requested review from
wwtamu and
gneissone
and removed request for
gneissone
brianjlowe
reviewed
Mar 20, 2025
home/src/main/resources/rdf/i18n/en_US/display/firsttime/pageNotFound.n3
Outdated
Show resolved
Hide resolved
brianjlowe
reviewed
Mar 20, 2025
home/src/main/resources/rdf/i18n/en_US/display/firsttime/pageNotFound.n3
Outdated
Show resolved
Hide resolved
brianjlowe
reviewed
Mar 20, 2025
home/src/main/resources/rdf/i18n/en_US/display/firsttime/pageNotFound.n3
Outdated
Show resolved
Hide resolved
…otFound.n3 Co-authored-by: Brian Lowe <[email protected]>
…otFound.n3 Co-authored-by: Brian Lowe <[email protected]>
…otFound.n3 Co-authored-by: Brian Lowe <[email protected]>
wwtamu
approved these changes
Mar 24, 2025
chenejac
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
Linked VIVO PR
What does this pull request do?
Specified application of locale selection filter on error requests.
Forward 404 errors to /page_not_found PageController
How should this be tested?
A description of what steps someone could take to:
Interested parties
@VIVO-project/vivo-committers @hauschke
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Reviewers' report template
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed