VIVO-4020 Order user accounts by last login time in descending order #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
reviewed
Mar 6, 2025
| @@ -33,6 +32,9 @@ public class UserAccountsSelectorTest extends AbstractTestClass { | |||
|
|
|||
| private static final String NS_MINE = "http://vivo.mydomain.edu/individual/"; | |||
|
|
|||
| private static final UserAccountsOrdering DEFAULT_ORDERING = new UserAccountsOrdering( | |||
There was a problem hiding this comment.
I suggest to change name of this static attribute to ACCOUNTS_ORDERING. It is not default ordering anymore (it is now last login, descending).
chenejac
approved these changes
Mar 6, 2025
|
Thanks a lot! A tiny change, but it is/was a really annoying thing to always reorder that page. 👍 |
ivanmrsulja
pushed a commit
to ivanmrsulja/Vitro
that referenced
this pull request
Apr 1, 2025
…ivo-project#492) * Order user accounts by last login time in descending order * fixed tests * Renamed ordering attribute in user accounts selector test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
What does this pull request do?
Changes default default sorting field to last login time.
Changes default order to descending.
How should this be tested?
Interested parties
@hauschke @vivo-project/vivo-committers
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Reviewers' report template
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed