Moving Data Distribution API into the Vitro codebase #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markuskotte agreed to review German language parts, when and if necessary. |
chenejac
requested changes
Feb 7, 2025
There was a problem hiding this comment.
@litvinovg thanks for nice and significant contribution. I have posted a couple of comments.
...ain/java/edu/cornell/library/scholars/webapp/controller/api/DistributeDataApiController.java
Outdated
Show resolved
Hide resolved
...u/cornell/library/scholars/webapp/controller/api/distribute/DataDistributionApi_overview.png
Outdated
Show resolved
Hide resolved
...ll/library/scholars/webapp/controller/api/distribute/rdf/graphbuilder/EmptyGraphBuilder.java
Outdated
Show resolved
Hide resolved
...library/scholars/webapp/controller/api/distribute/rdf/graphbuilder/ParallelGraphBuilder.java
Outdated
Show resolved
Hide resolved
...brary/scholars/webapp/controller/api/distribute/rdf/graphbuilder/ThreadsafeGraphBuilder.java
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/en_US/interface-i18n/firsttime/vitro_UiLabel.ttl
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/en_US/interface-i18n/firsttime/vitro_UiLabel.ttl
Show resolved
Hide resolved
chenejac
requested changes
Feb 14, 2025
...ain/java/edu/cornell/library/scholars/webapp/controller/api/DistributeDataApiController.java
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/en_US/interface-i18n/firsttime/vitro_UiLabel.ttl
Show resolved
Hide resolved
litvinovg
force-pushed
the
VIVO-4027+
branch
from
92dabdc to
301dfd1
Compare
takeover from graham rm unimplemented or unnecessary classes rm unused distributors added us text for vqt use local server port to make new request instead of port used by the client fix self signed certificate issue Renamed german translation properties checkstyle fixes
This reverts commit 7c2f665991b94c8d9f7e4f38342502815a4be8f7.
This reverts commit 915f96dc8549f11aad44c62a21f5096e02345528.
…ge and not used translations
…issions for each report.
…ta distributor edit pages
chenejac
previously approved these changes
Mar 12, 2025
ivanmrsulja
reviewed
Mar 25, 2025
...a/edu/cornell/library/scholars/webapp/controller/api/distribute/rdf/util/VariableBinder.java
Outdated
Show resolved
Hide resolved
| RoleInfo roleCopy = role.clone(); | ||
| roleInfos.add(roleCopy); | ||
| operationsToRoles.put(operation.toLowerCase(), roleInfos); | ||
| for (String roleUri : roles.keySet()) { |
There was a problem hiding this comment.
I believe that iterating using (Map.Entry<String, Map<String, Boolean>> entry : operations.entrySet()) will be more efficient.
There was a problem hiding this comment.
Do you see a performance issue there?
Suggested code looks less readable to me.
| } else { | ||
| EntityPolicyController.revokeAccess(entityUri, aot, ao, role.getUri()); | ||
| if (Boolean.TRUE.equals(roles.get(role))) { |
There was a problem hiding this comment.
Is Boolean.TRUE.equals() used for better readability?
api/src/main/java/edu/cornell/mannlib/vitro/webapp/auth/policy/PolicyLoader.java
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/reporting/OpenDopeWordReport.java
Outdated
Show resolved
Hide resolved
| public void generateReport(OutputStream outputStream, RequestModelAccess request, UserAccount account) | ||
| throws ReportGeneratorException { | ||
| // Get the XML | ||
| Document xmlDoc = generateXml(request, account); |
api/src/main/java/edu/cornell/mannlib/vitro/webapp/reporting/OpenDopeWordReport.java
Outdated
Show resolved
Hide resolved
.../scholars/webapp/controller/api/distribute/file/SelectingFileDistributor_FileFinderTest.java
Outdated
Show resolved
Hide resolved
chenejac
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
What does this pull request do?
Added the Data Distribution API and report generation into Vitro codebase.
Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
Interested parties
@chenejac @hauschke @brianjlowe
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Reviewers' report template
Please update the following template which should be used by reviewers.
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed