Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Go-SDK for OpenFass API #9

Merged
merged 3 commits into from
Feb 7, 2020
Merged

Fix Go-SDK for OpenFass API #9

merged 3 commits into from
Feb 7, 2020

Conversation

akshaydotsh
Copy link
Contributor

@akshaydotsh akshaydotsh commented Jan 31, 2020

This adds Go-SDK for openfaas/faas#1246

Fix Go-SDK for OpenFass API

To run integration test

go test -tags=integration

Problem Pending

  • UpdateFunction, ScaleFunction failing in integration test with error:
rpc error: code = 2 desc = update out of sequence

probably problem with container not spinning up completely before calling update and scaling funcs

Copy link
Contributor

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In test cases we should not handle errors, either expect an error or no error.

go_faas_integration_test.go Show resolved Hide resolved
go_faas_integration_test.go Outdated Show resolved Hide resolved
go_faas_integration_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anilcse anilcse merged commit 25c5e77 into master Feb 7, 2020
@anilcse anilcse changed the title Integration Tests Fix Go-SDK for OpenFass API Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants