Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] Fix: Separate Lock for Keyspace to Update Controller Mapping in Schema Tracking (#17873) #17884

Open
wants to merge 2 commits into
base: release-20.0
Choose a base branch
from

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Mar 3, 2025

Description

This is a backport of #17873

Copy link
Contributor Author

vitess-bot bot commented Mar 3, 2025

Hello @harshit-gangal, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 17884 -R vitessio/vitess
git reset --hard origin/release-20.0
git cherry-pick -m 1 1582d5b7c8e9e80f845020983d9218e847f061c8

Copy link
Contributor Author

vitess-bot bot commented Mar 3, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot requested a review from harshit-gangal March 3, 2025 11:20
@github-actions github-actions bot added this to the v20.0.7 milestone Mar 3, 2025
@harshit-gangal harshit-gangal removed the Skip CI Skip CI actions from running label Mar 3, 2025
@harshit-gangal harshit-gangal marked this pull request as ready for review March 3, 2025 15:38
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.41%. Comparing base (254b0fe) to head (10a6f80).

Files with missing lines Patch % Lines
go/vt/vtgate/schema/tracker.go 86.66% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #17884      +/-   ##
================================================
- Coverage         66.42%   66.41%   -0.02%     
================================================
  Files              1543     1543              
  Lines            244650   244661      +11     
================================================
- Hits             162513   162480      -33     
- Misses            82137    82181      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants