-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DDL: removal of gh-ost
and pt-osc
strategies
#17626
Conversation
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Shlomi Noach <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17626 +/- ##
==========================================
+ Coverage 67.77% 67.97% +0.19%
==========================================
Files 1587 1586 -1
Lines 255798 255106 -692
==========================================
+ Hits 173379 173412 +33
+ Misses 82419 81694 -725 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Documentation: vitessio/website#1933 |
Documentation added. Good to review/merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋👻
Signed-off-by: Shlomi Noach <[email protected]>
Description
This PR completely removes any
gh-ost
andpt-online-schema-change
support, functionality, and flags from Vitess Online DDL.This means all of the following yields errors:
The remaining strategies are:
vitess
(akaonline
, both are allowed)mysql
(not Online, but still managed)direct
(unmanaged)Documentation: vitessio/website#1933
Related Issue(s)
gh-ost
andpt-osc
Online DDL strategies #15692gh-ost
DDL strategy #15693gh-ost
website#1725Checklist
Deployment Notes