Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DDL: removal of gh-ost and pt-osc strategies #17626

Merged
merged 12 commits into from
Feb 6, 2025

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Jan 26, 2025

Description

This PR completely removes any gh-ost and pt-online-schema-change support, functionality, and flags from Vitess Online DDL.

This means all of the following yields errors:

$ vtctldclient ApplySchema --ddl-strategy="gh-ost" ...
$ vtctldclient ApplySchema --ddl-strategy="pt-osc" ...
$ vttablet --gh-ost-path=...
$ vttablet --pt-osc-path=...

The remaining strategies are:

  • vitess (aka online, both are allowed)
  • mysql (not Online, but still managed)
  • direct (unmanaged)

Documentation: vitessio/website#1933

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Jan 26, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 26, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 26, 2025
@shlomi-noach shlomi-noach added Type: Internal Cleanup release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 26, 2025
Signed-off-by: Shlomi Noach <[email protected]>
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.97%. Comparing base (71b2cae) to head (5ec56a9).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/onlineddl/executor.go 0.00% 2 Missing ⚠️
go/vt/vtctl/vtctl.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17626      +/-   ##
==========================================
+ Coverage   67.77%   67.97%   +0.19%     
==========================================
  Files        1587     1586       -1     
  Lines      255798   255106     -692     
==========================================
+ Hits       173379   173412      +33     
+ Misses      82419    81694     -725     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shlomi-noach
Copy link
Contributor Author

Documentation: vitessio/website#1933

@shlomi-noach shlomi-noach marked this pull request as ready for review February 5, 2025 09:57
@shlomi-noach
Copy link
Contributor Author

Documentation added. Good to review/merge.

Copy link
Contributor

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋👻

Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach removed the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Feb 6, 2025
@shlomi-noach shlomi-noach merged commit cf28afa into vitessio:main Feb 6, 2025
104 of 105 checks passed
@shlomi-noach shlomi-noach deleted the remove-gh-ost-pt-osc branch February 6, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants