-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch Keyspace Records in VTOrc instead of polling them #17553
Draft
GuptaManan100
wants to merge
12
commits into
vitessio:main
Choose a base branch
from
planetscale:keyspace-watcher-vtorc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,227
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuptaManan100
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: VTorc
Vitess Orchestrator integration
labels
Jan 16, 2025
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 16, 2025
GuptaManan100
added
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
and removed
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsWebsiteDocsUpdate
What it says
labels
Jan 16, 2025
…exact shard values Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
…vers Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
…s being deleted Signed-off-by: Manan Gupta <[email protected]>
…ime tick Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
force-pushed
the
keyspace-watcher-vtorc
branch
from
January 22, 2025 14:53
6e164aa
to
78e60e2
Compare
Signed-off-by: Manan Gupta <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17553 +/- ##
==========================================
+ Coverage 67.68% 67.70% +0.01%
==========================================
Files 1586 1586
Lines 255170 255486 +316
==========================================
+ Hits 172722 172982 +260
- Misses 82448 82504 +56 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: VTorc
Vitess Orchestrator integration
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist
Deployment Notes