Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Handle --vreplication_experimental_flags options properly for partial images #17428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Dec 24, 2024

Description

This is a quick follow-up to #17345

In backporting this in a fork, where the --vreplication_experimental_flags were being handled differently — 1) the noblob support was disabled in all unit tests except the noblob ones 2) vplayer batching was not enabled — I noticed some incorrect behavior.

Those fixes and adjustments are made here.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Dec 24, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 24, 2024
@mattlord mattlord removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 24, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Dec 24, 2024
@mattlord mattlord force-pushed the vrepl_efficient_repl_followup branch 2 times, most recently from fd3b43d to 28adbec Compare December 24, 2024 17:44
@mattlord mattlord changed the title VReplication: Handle --vreplication_experimental_flags options properly VReplication: Handle --vreplication_experimental_flags options properly for partial images Dec 24, 2024
@mattlord mattlord force-pushed the vrepl_efficient_repl_followup branch from 28adbec to ebc71af Compare December 24, 2024 18:10
@mattlord mattlord force-pushed the vrepl_efficient_repl_followup branch from ebc71af to df3171e Compare December 24, 2024 18:16
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.66%. Comparing base (059d01a) to head (df3171e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17428      +/-   ##
==========================================
- Coverage   67.68%   67.66%   -0.02%     
==========================================
  Files        1583     1583              
  Lines      254321   254319       -2     
==========================================
- Hits       172131   172079      -52     
- Misses      82190    82240      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant