-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CobraDocs: Remove commit hash from docs. Fix issue with workdir replacement #17392
Open
rohit-nayak-ps
wants to merge
7
commits into
vitessio:main
Choose a base branch
from
planetscale:rohit/docgen-remove-commit-fix-workdir-replace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CobraDocs: Remove commit hash from docs. Fix issue with workdir replacement #17392
rohit-nayak-ps
wants to merge
7
commits into
vitessio:main
from
planetscale:rohit/docgen-remove-commit-fix-workdir-replace
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
added
Type: Documentation
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Documentation
docs related issues/PRs
labels
Dec 14, 2024
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 14, 2024
Signed-off-by: Rohit Nayak <[email protected]>
Draft
1 task
Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 15, 2024
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17392 +/- ##
==========================================
+ Coverage 67.47% 67.53% +0.05%
==========================================
Files 1581 1581
Lines 253944 253956 +12
==========================================
+ Hits 171353 171503 +150
+ Misses 82591 82453 -138 ☔ View full report in Codecov by Sentry. |
rohit-nayak-ps
requested review from
ajm188,
deepthi and
mattlord
as code owners
December 15, 2024 17:31
mattlord
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Documentation
docs related issues/PRs
Type: Documentation
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sed
command to replace<WORKDIR>
due to incorrect sed invocation. Fixed here.WORKDIR
sed was not happening. AddedRelated Issue(s)
There is a related website PR vitessio/website#1904 which will enhance the current
make
target to generate the docs to add modified content files to git with an appropriate git message including the current vitess hash.We need to first merge this PR into main and then run
make generated-docs
in the website PR before it is ready.Checklist
Deployment Notes