Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPERIMENTAL] VPlayer parallel applier #17370

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

shlomi-noach
Copy link
Contributor

Description

EXPERIMENTAL only. Details to come. Right now just looking at a potential for parallel applier based on WRITESET and benchmarking parallel vs. linear performance (local benchmarking is inconclusive).

Related Issue(s)

TBD.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Dec 11, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 11, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Dec 11, 2024
Signed-off-by: Shlomi Noach <[email protected]>
- Improve `drain()` logic
- `drain()` returns workers error
- Wait for `drain()` to complete
- Parallel worker is a local variable
- Extract parallel counters outside loop
- Check workers error when replacing parallel worker
- Batch commits
- Parallel pool is a local variable
- isApplicable: optimize for when the worker is at head (skip mutex)
- isApplicable: dependency logic for batches commits: current event/s lastCommitted compared with existing workers/ sequenceNumber
- Worker: issue Rollback if terminated within transaction
- Worker: check context cancellation
- Worker: use `VEventType_UNKNOWN` as a serialization hint.

Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VReplication NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says Type: Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant