Skip to content

Conversation

@patak-dev
Copy link
Member

Description

Better naming for official starters, that will make even more sense after we merge:

sapphi-red
sapphi-red previously approved these changes Jan 9, 2025
@sapphi-red sapphi-red added p2-nice-to-have Not breaking anything but nice to have (priority) feat: create-vite create-vite package labels Jan 9, 2025
bluwy
bluwy previously approved these changes Jan 9, 2025
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to update this together? Maybe "Extra Vite templates" and "Electron".

name: 'others',
display: 'Others',
color: reset,
variants: [
{
name: 'create-vite-extra',
display: 'create-vite-extra ↗',
color: reset,
customCommand: 'npm create vite-extra@latest TARGET_DIR',
},
{
name: 'create-electron-vite',
display: 'create-electron-vite ↗',
color: reset,
customCommand: 'npm create electron-vite@latest TARGET_DIR',
},
],
},
]

@patak-dev patak-dev dismissed stale reviews from bluwy and sapphi-red via 05d5135 January 9, 2025 12:22
@patak-dev
Copy link
Member Author

Ah, yes! Went with "Extra Vite Starters" to align with the other names.

@sapphi-red sapphi-red merged commit 1992f68 into main Jan 24, 2025
24 checks passed
@sapphi-red sapphi-red deleted the feat/create-vite-options-naming branch January 24, 2025 03:15
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: create-vite create-vite package p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants