fix(create-vite): update tsconfig with moduleDetection force #17468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #17443
Problem solved:
With the current configuration, the application may compile successfully but fail at runtime.
Reproducible example here:https://stackblitz.com/edit/vitejs-vite-srbrdd
Reproduction
https://stackblitz.com/edit/vitejs-vite-srbrdd?file=tsconfig.json
Steps to reproduce
ts
file inside thesrc
folder (for examplenewfile.ts
) with this content:const MY_CONST = 1
App.tsx
:{MY_CONST}
,At this point, you should be able to compile (with
npx tsc --noEmit
) or build the app (npm run build
) without errors, but the app fails at runtime (npm run dev
) in the preview.Notes:
I was only able to reproduce this with the react and react templates.