Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin ci windows node version #17435

Merged
merged 1 commit into from
Jun 10, 2024
Merged

chore: pin ci windows node version #17435

merged 1 commit into from
Jun 10, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jun 10, 2024

Description

Pin to 20.13.1. Maybe this will fix the error.


  #  node (vitest)[4740]:  at c:\ws\src\node_file.cc:966
  #  Assertion failed: (req_wrap_async) != nullptr

----- Native stack trace -----

 ✓ packages/vite/src/node/__tests__/plugins/importGlob/utils.spec.ts  (6 tests) 8ms
 ✓ packages/vite/src/node/server/__tests__/moduleGraph.spec.ts  (2 tests) 9ms
 ✓ packages/vite/src/node/__tests__/plugins/json.spec.ts  (1 test) 4ms
 ✓ packages/vite/src/node/ssr/__tests__/ssrExternal.spec.ts  (2 tests) 47ms
 1: 00007FF638F46CEB node::SetCppgcReference+18123
 2: 00007FF638EB6B31 v8::base::CPU::num_virtual_address_bits+82705
 3: 00007FF638E9A402 v8::base::CPU::has_fpu+49202
 4: 00007FF6398E65EE v8::SharedValueConveyor::SharedValueConveyor+416270
 5: 00007FF6398E61EA v8::SharedValueConveyor::SharedValueConveyor+415242
 6: 00007FF6398E64AF v8::SharedValueConveyor::SharedValueConveyor+415951
 7: 00007FF6398E6320 v8::SharedValueConveyor::SharedValueConveyor+415552
 8: 00007FF6399E198E v8::PropertyDescriptor::writable+677838
 9: 0000028920129A3E 

----- JavaScript stack trace -----

1: access (node:internal/fs/promises:604:13)
2: search (D:\a\vite\vite\node_modules\.pnpm\[email protected]\node_modules\lilconfig\dist\index.js:105:43)


 ELIFECYCLE  Command failed with exit code 134.
Error: Process completed with exit code 1.

Copy link

stackblitz bot commented Jun 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a rerun of the Windows CI, and in both it worked. This looks good to me!

@bluwy bluwy merged commit a826a08 into main Jun 10, 2024
11 checks passed
@bluwy bluwy deleted the pin-windows-node branch June 10, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants