Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(v6): add runner dynamic import test #17422

Closed
wants to merge 4 commits into from
Closed

test(v6): add runner dynamic import test #17422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7e8cfb
test(v6): add runner dynamic import test
hi-ogawa Jun 8, 2024
213858f
test: add test to server-runtime.spec.ts
hi-ogawa Jun 10, 2024
9171611
Revert "test(v6): add runner dynamic import test"
hi-ogawa Jun 10, 2024
9f5c59f
test: tweak
hi-ogawa Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/vite/src/node/ssr/runtime/__tests__/fixtures/dynamic-import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as staticModule from './basic'
import path from "node:path";

export const initialize = async () => {
const nameRelative = './basic'
Expand All @@ -9,6 +10,7 @@ export const initialize = async () => {
dynamicRelative: await import(nameRelative),
dynamicAbsolute: await import(nameAbsolute),
dynamicAbsoluteExtension: await import(nameAbsoluteExtension),
dynamicAbsoluteFull: await import(path.join(import.meta.dirname, "basic.js")),
static: staticModule,
}
}
1 change: 1 addition & 0 deletions packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@
expect(modules.static).toBe(modules.dynamicRelative)
expect(modules.static).toBe(modules.dynamicAbsolute)
expect(modules.static).toBe(modules.dynamicAbsoluteExtension)
expect(modules.static === modules.dynamicAbsoluteFull).toBe(true)

Check failure on line 172 in packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts

View workflow job for this annotation

GitHub Actions / Build&Test: node-18, ubuntu-latest

packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts > module runner initialization > dynamic import doesn't produce duplicates 

AssertionError: expected false to be true // Object.is equality

- Expected
+ Received

- true
+ false

 ❯ packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts:172:60

Check failure on line 172 in packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts

View workflow job for this annotation

GitHub Actions / Build&Test: node-20, ubuntu-latest

packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts > module runner initialization > dynamic import doesn't produce duplicates 

AssertionError: expected false to be true // Object.is equality

- Expected
+ Received

- true
+ false

 ❯ packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts:172:60

Check failure on line 172 in packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts

View workflow job for this annotation

GitHub Actions / Build&Test: node-22, ubuntu-latest

packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts > module runner initialization > dynamic import doesn't produce duplicates 

AssertionError: expected false to be true // Object.is equality

- Expected
+ Received

- true
+ false

 ❯ packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts:172:60
})

it('correctly imports a virtual module', async ({ runner }) => {
Expand Down
Loading