Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): page reload was not happening with .css?raw #16455

Merged
merged 2 commits into from May 18, 2024

Conversation

sapphi-red
Copy link
Member

Description

fixes #16396

@sapphi-red sapphi-red added feat: css feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release labels Apr 18, 2024
Copy link

stackblitz bot commented Apr 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

/ecosystem-ci run

@sapphi-red
Copy link
Member Author

I reran nuxt but it failed again. It seems this PR does affect nuxt and astro. 🤔

@sapphi-red
Copy link
Member Author

@bluwy Would you take a look why this breaks astro?

@bluwy
Copy link
Member

bluwy commented Apr 30, 2024

I sent a PR to Astro to fix this. It was incorrectly crawling into the dependencies to find CSS to inline. Skipping it fixes it.

@sapphi-red
Copy link
Member Author

Thanks 🙏

@sapphi-red
Copy link
Member Author

/ecosystem-ci run

@bluwy bluwy merged commit 8041846 into vitejs:main May 18, 2024
11 checks passed
@sapphi-red sapphi-red deleted the fix/css-raw-hmr branch May 18, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page reload not working for ?raw CSS imports
3 participants