feat(create-vite): add help usage #16390
Open
+52
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- help argument will be used as "--help" and by default it is false
- i want to find a way to decouple the text from the code
|
|
edvardsanta
changed the title
edvardsanta
changed the title
- Using alias to define template and help
bluwy
reviewed
May 18, 2024
| function getUsageInfo() { | ||
| const formattedFrameworkNames = getFormattedVariantNames() | ||
| return `Usage: create-vite [OPTION]... [DIRECTORY] | ||
| Create a new JavaScript project based on Vite. |
There was a problem hiding this comment.
nit
Suggested change
| Create a new JavaScript project based on Vite. | |
| Create a new Vite project in JavaScript or TypeScript. |
Comment on lines
+597
to
+604
| function getFormattedVariantNames() { | ||
| return FRAMEWORKS.filter( | ||
| (framework) => framework.name !== 'others' && framework.variants.length > 0, | ||
| ).map((framework) => { | ||
| const variantNames = framework.variants.map((variant) => variant.name) | ||
| return `${variantNames.join(' ')}` | ||
| }) | ||
| } |
There was a problem hiding this comment.
I think we should also put the variants each on their new line as well, otherwise it may be hard to read if some are on a single line.
Also, I think we should filter out the templates that have customCommand as they're redirects to other CLIs.
bluwy
added
p2-nice-to-have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #16374
