feat(create-vite): add help usage #16390
Conversation
- help argument will be used as "--help" and by default it is false
- i want to find a way to decouple the text from the code
|
|
edvardsanta
changed the title
edvardsanta
changed the title
- Using alias to define template and help
bluwy
added
p2-nice-to-have
- To improve maintainability, the help message has been moved to a separate file. - Implemented the suggestions provided in the pull request.
|
Pushed a commit with some styling changes after discussing with other maintainers, here's how it looks now: The hardcoding isn't the most ideal, but I think it simplifies the code a lot and the templates aren't something we update often. |
Wouldn't it be interesting to use the color properties in the Framework type? It would make the process more dynamic instead of manually creating them for each new framework. Edit: It can be a technical debt. I will try to make some modifications in the future |
|
Yeah I did try that but to do so and others, it slows creeps in as a lot of code compared to hardcoding. So I leaned directly to the simplest way for now. |
I tried to make it more dynamic, but I forgot that we have four types of React, and the variants ended up looking strange. |
|
Yeah that was also the part where I threw my hand and went for the simpler path instead 😄 It's hard to sort that one with a specific hardcoding too. |
Description
closes #16374
