fix(ssrTransform): handle arbitrary module namespace identifiers

vitejs · Jun 12, 2024 · 4f50e69 · 4f50e69
1 parent ec287f8
commit 4f50e69
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts b/packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts
@@ -120,6 +120,17 @@ test('export * as from', async () => {
  `)
 })
 
+test.only('export as arbitrary module namespace identifier', async () => {
+ expect(
+ await ssrTransformSimpleCode(
+ `const something = "Something";export { something as "arbitrary string" };`,
+ ),
+ ).toMatchInlineSnapshot(`
+ "const something = "Something";
+ Object.defineProperty(__vite_ssr_exports__, "arbitrary string", { enumerable: true, configurable: true, get(){ return something }});" 
+ `)
+})
+
 test('export default', async () => {
  expect(
  await ssrTransformSimpleCode(`export default {}`),

diff --git a/packages/vite/src/node/ssr/ssrTransform.ts b/packages/vite/src/node/ssr/ssrTransform.ts
@@ -194,9 +194,15 @@ async function ssrTransformScript(
  },
  )
  for (const spec of node.specifiers) {
+ const exportedAs =
+ spec.exported.type === 'Identifier'
+ ? spec.exported.name
+ : // @ts-expect-error TODO: Estree types don't consider arbitrary module namespace specifiers yet
+ spec.exported.value
+
  defineExport(
  node.start,
- spec.exported.name,
+ exportedAs,
  `${importId}.${spec.local.name}`,
  )
  }
@@ -205,7 +211,14 @@ async function ssrTransformScript(
  for (const spec of node.specifiers) {
  const local = spec.local.name
  const binding = idToImportMap.get(local)
- defineExport(node.end, spec.exported.name, binding || local)
+
+ const exportedAs =
+ spec.exported.type === 'Identifier'
+ ? spec.exported.name
+ : // @ts-expect-error TODO: Estree types don't consider arbitrary module namespace specifiers yet
+ spec.exported.value
+
+ defineExport(node.end, exportedAs, binding || local)
  }
  }
  }