Add solid-router to vite-ecosystem-ci #346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the solid-router test suite to the vite-ecosystem-ci.
It introduces to the vite-ecosystem-ci some amount of coverage for both
@solidjs/routerand vite-plugin-solid.It doesn't cover the solid-start repo / vinxi repo, which currently handles the file-based routing and nitro integration.
The terminal output from this suite is:
✓ test/utils.spec.ts (71 tests) 12ms ✓ test/route.spec.ts (28 tests) 9ms ✓ test/integration.spec.ts (7 tests) 7ms ✓ test/router.spec.ts (24 tests) 75ms Test Files 5 passed (5) Tests 131 passed (131) Start at 18:40:31 Duration 1.16s (transform 449ms, setup 0ms, collect 1.12s, tests 105ms, environment 1.88s, prepare 339ms)