Persist default locale #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first version of the default locale feature a non-persisted instance of
Rosetta::Locale. It made sense since the convention in Rosetta is that your default locale is the locale the codebase is written in. Therefore there should be no need for a persisted default locale.However, work on #10 showed that in order to have a common pluralization API, pluralized translations need to be stored, even for the default locale. Therefore it needs to be persisted.
This PR implements a new workflow around default locales. Any installation of Rosetta without a persisted default locale will now redirect to
default_locales#new. A new booleandefaultis added to therosetta_localestable to set the default locale.The default locale is memoized in
Rosetta::Locale.default_locale.The default Locale should not change in theory. It should only be set once.