Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not explicitly build static lib #293

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

topazus
Copy link
Contributor

@topazus topazus commented Aug 14, 2024

It is better to set BUILD_SHARED_LIBS option to build shared or static lib than to explicitly build the library as static.

It is better to set BUILD_SHARED_LIBS option to build shared or static lib than
to explicitly build the library as static.
@zccrs zccrs requested a review from wineee August 19, 2024 06:52
@wineee
Copy link
Member

wineee commented Aug 19, 2024

qwlroots was originally intended to be a header only library, but the remaining small amount of implementation is in cpp
1, 2, using dynamic libraries will not significantly reduce the size of program, and I prefer to build qwlroots as static libraries by default

@felixonmars
Copy link

Applied in Arch packaging as well. We also prefer shared libraries generally as a distribution.

@zccrs zccrs merged commit 5b678d0 into vioken:master Feb 5, 2025
16 of 19 checks passed
@zccrs
Copy link
Contributor

zccrs commented Feb 5, 2025

Thanks.

1 similar comment
@zccrs
Copy link
Contributor

zccrs commented Feb 5, 2025

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants