[CLOYSTER-121] Fix the most severe TUI bugs #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The network interface code was trying to get a gateway IP that did not exist. We also added some error handling in all address conversion code because of this
From @viniciusferrao: > 3. -v não deveria printar que o programa deu start, é para retornar a versão apenas. > > 4. Opção -D é bogus. Não tem daemon funcionando ainda. > > 5. O check de rodar como root não está funcionando. No verification.cpp; rodei como user e aceitou. Deveria jogar um runtime error. Existe uma opção -r que não entendi o propósito. > > 6. A opção de CLI (`-c`) está OK. Ela diz que não foi implemtado ainda, mas não deveria dar o started. Tem que talvez tirar a opção com #ifdef. > > 7. Quando chama a TUI (`-t`); ele ja fala que AGORA VAI modificar o cluster. Como se ainda nem perguntou nada? Isso é para vir depois de terminar de carregar as coisas/preencher a TUI. > > 8. Na TUI só tem a opção para um timeserver de NTP. Não dá para colocar mais de um.
- the repository screen now does not stay in the background after repo selected - the ISO selection screen now gives an error and allow retry if the iso directory does not exist - you can select more than one time server
Upgrade the compiler to c++23 so we can equiparate our development environment to what SonarCloud warnings expects us to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the most severe bugs in the TUI, and also some of the easiest issues to solve