Improve answerfile code and add unit tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lbgracioso <[email protected]>
# Conflicts: # src/answerfile.cpp
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
|
Sorry about the last commit misspelled message. 5AM here and I just woke up. Anyways, already fixed. |
Signed-off-by: lbgracioso <[email protected]>
|
|
Hi @lbgracioso thanks for the code. I've approved because it seems good but theres only one thing that I didn't quite understand that was the whole Take a look here: https://www.reddit.com/r/cpp/comments/188if0y/comment/kbkvgj7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
In this PR I was finally able to clean the answerfile code (refactor) and add unit tests to it.
tests.hfile to organize tests better.inifile.cpp(next PR should be about it)