Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve answerfile code and add unit tests #50

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

lbgracioso
Copy link
Collaborator

Hey,
In this PR I was finally able to clean the answerfile code (refactor) and add unit tests to it.

  1. Code refactor and improvement
  2. New tests.h file to organize tests better.
  3. New unit tests
  4. Small change in inifile.cpp (next PR should be about it)

# Conflicts:
#	src/answerfile.cpp
Signed-off-by: lbgracioso <[email protected]>
@lbgracioso lbgracioso added the enhancement New feature or request label Mar 11, 2024
@lbgracioso
Copy link
Collaborator Author

Sorry about the last commit misspelled message. 5AM here and I just woke up. Anyways, already fixed.

Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@viniciusferrao viniciusferrao merged commit bf04d29 into viniciusferrao:master Apr 2, 2024
2 checks passed
@viniciusferrao
Copy link
Owner

Hi @lbgracioso thanks for the code. I've approved because it seems good but theres only one thing that I didn't quite understand that was the whole canBeNull variable. Wouldn't that be a std::optional<bool>?

Take a look here: https://www.reddit.com/r/cpp/comments/188if0y/comment/kbkvgj7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants